Release learnr 0.11.3 - Githubissues

rstudio / learnr

Interactive Tutorials with R Markdown

https://pkgs.rstudio.com/learnr

Apache License 2.0

705 stars 236 forks source link

Release learnr 0.11.3 #768

Closed gadenbuie closed 1 year ago

gadenbuie commented 1 year ago

[x] git pull
[x] Check current CRAN check results
- NOTE: Undeclared packages ‘sortable’, ‘bslib’ in Rd xrefs
[x] Polish NEWS
- Patch release, so the current structure should be fine
[x] urlchecker::url_check()
[x] devtools::build_readme()
[x] devtools::check(remote = TRUE, manual = TRUE)
[x] devtools::check_win_devel()
[x] revdepcheck::cloud_check()
[x] Update cran-comments.md
[x] git push

Submit to CRAN:

[x] usethis::use_version('patch')
[x] devtools::submit_cran()
[x] Approve email

Wait for CRAN...

[x] Accepted :tada:
[ ] usethis::use_github_release()
[ ] usethis::use_dev_version(push = TRUE)

rossellhayes commented 1 year ago

@gadenbuie We're currently getting this NOTE:

Undeclared packages ‘sortable’, ‘bslib’ in Rd xrefs

Are we purposefully leaving those packages out of Suggests?

gadenbuie commented 1 year ago

I don't mind the NOTE (unless CRAN does) so my stance has been to ignore it for now. I don't think anything bad happens for users if they look at those docs but don't have bslib or sortable. I personally don't think documentation links are a strong enough reason to suggest a package, but if I'm overlooking a problem, or if CRAN asks, I'd add them.

schloerke commented 1 year ago

What about replacing the link to their respective websites?

gadenbuie commented 1 year ago

Or that. Or... roxygen2 should have an "if installled" link type that does that for us automatically. 😊

But if the only harms are the note and a non-link I'm not convinced a change is needed. (If an invalid link is generated, that would change my mind for sure.)

gadenbuie commented 1 year ago

If the package isn't installed, the link is broken. I'll add both packages to Suggests.