rstudio / learnr

Interactive Tutorials with R Markdown
https://pkgs.rstudio.com/learnr
Apache License 2.0
705 stars 236 forks source link

Update keyboard shortcut to insert native pipe #786

Closed statik closed 9 months ago

statik commented 1 year ago

This change updates the keyboard shortcuts in interactive tutorials to insert the native pipe instead of magrittr pipe.

If you would like this to be a configurable option, I'm happy to do more work to make it configurable - it wasn't obvious to me how to make this configurable at first.

I got some failures from devtools::check() but doubt those are related to my changes, I am unsure if I have my local dev environment correctly configured.

PR task list:

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

gadenbuie commented 1 year ago

This should definitely be configurable, but we currently don't have much infrastructure for setting or communicating the preference.

Here's a quick brain dump of an idea:

gadenbuie commented 9 months ago

@statik thanks for this PR! I ended up going in a slightly different direction in #804 that allows the pipe to be set at the level of a tutorial or even at the level of a specific exercise. Let me know what you think!