search

rstudio / packrat

Packrat is a dependency management system for R
http://rstudio.github.io/packrat/
402 stars 90 forks source link

Add support for Artifactory archive types #583

Open cfmack opened 5 years ago

cfmack commented 5 years ago

In RTFACT-17392, Artifactory has a bug dealing with how CRAN archives. While that is indeed a bug, I have found in 3.5.1 install.packages, varying implementation of REMOTES, and/or versions of packrat, each package attempt to solve these varying implementations differently. Some need to reference a "archive.rds". Others must have a package.rds while others sufficiently use a PACKAGE file.

The ask and the associated PR is allowing the loosening of these restrictions to be backwards compatible. Remotes has a similar bug and PR

pyltime commented 1 year ago

This has come up with a customer using Posit Connect in support ticket 90580.

kevinushey commented 1 year ago

We have a solution for this on the renv side; perhaps we could port the relevant code to Packrat? That code lives here: https://github.com/rstudio/renv/blob/029c4457c0c2846eafd9a1da8bf3f95daf49fe45/R/retrieve.R#L806-L860

jimhester commented 1 year ago

The recent version of Connect which bundles a newer version of packrat exposed us to this issue as well. It would be great to either adapt the code from the linked PR or the linked renv solution to support this.

In the short term I have patched the vendored version of packrat for our use, but it would be great to avoid this workaround and use the one bundled with Connect.