search

rstudio / packrat

Packrat is a dependency management system for R
http://rstudio.github.io/packrat/
401 stars 89 forks source link

avoid repeated package dependency processing #615

Closed aronatkins closed 3 years ago

aronatkins commented 3 years ago

an alternate tree-pruning approach from #614; part of an ongoing discussion with @andrie

kevinushey commented 3 years ago

This PR looks good to me, although I think we might need to narrow the scope a bit more since (if I understand the test failures correctly) some APIs do rely on us building the full dependency tree for packages.

What if we instead hid this behavior behind an option, e.g. something like options(packrat.PruneDependencyTree = TRUE), and set that for rsconnect's usages of Packrat?

aronatkins commented 3 years ago

Updated the approach to prune the search while still producing the full dependency tree.

kevinushey commented 3 years ago

LGTM! (Remaining test failures are due to dependent R packages not being available for older R.)