Closed aronatkins closed 2 years ago
@kevinushey - downloadWithRetries
no longer calls the githubDownload
family of functions. They were always being called outside downloadWithRetries
whenever the canUseGitHubDownloader
family of functions was truthy.
In other words: The code was live and we checked the logic, but it would never actually dispatch to the githubDownload
function because getSourceForPkgRecord
always bypasses downloadWithRetries
when canUseGitHubDownloader
.
Related: I think we will eventually want downloadWithRetries
to expose more information about its download errors, but did not want to tackle that with this work.
Received a verbal +1 from @kevinushey.
We have started seeing errors when folks are using packrat to install private GitHub packages. This is rooted in the fact that
devtools
has removed thegithub_pat
function in its 2.4.3 release.R errors such as the lack of
devtools::github_pat
would now appear like:HTTP errors would now appear like:
Fixes #651