search

rstudio / packrat

Packrat is a dependency management system for R
http://rstudio.github.io/packrat/
401 stars 89 forks source link

Bitbucket download flow seems to be broken in `getSourceForPkgRecord()` #671

Closed toph-allen closed 2 years ago

toph-allen commented 2 years ago

In the Bitbucket download flow in getSourceForPkgRecord(), execution stops with a FAILED message when status is TRUE. However, this status is returned after a successful download.

https://github.com/rstudio/packrat/blob/1e13f7b582c80a00d701a36303ee0e20196436ca/R/restore.R#L367-L379

The fix should be a single character — prepending ! to status on that line.

toph-allen commented 2 years ago

Note to self: check that GitLab works too.

toph-allen commented 2 years ago

This has been verified. Ongoing work in #673.