search

rstudio / packrat

Packrat is a dependency management system for R
http://rstudio.github.io/packrat/
401 stars 89 forks source link

Fix Bitbucket and GitLab download calls in `getSourceForPkgRecord()` #672

Closed toph-allen closed 2 years ago

toph-allen commented 2 years ago

Intent

Fix archive downloads for Bitbucket and GitLab source archives when they're called in getSourceForPkgRecord().

Fixes #671

Approach

At first, I just flipped the polarity of the conditional evaluating the bitbucketDownload() and gitlabDownload() functions' output. But then I saw that the GitHub download workflow had been updated, so I modified Bitbucket and GitLab's download flow to follow GitHub's.

QA Notes

Still thinking about this.

Checklist

toph-allen commented 2 years ago

Note: Local tests seem to not be very broken. We'll see how CI fares.

toph-allen commented 2 years ago

GitLab downloads are still broken. Tracked in #673.

toph-allen commented 2 years ago

Other than that, this has been verified.