search

rstudio / pagedown

Paginate the HTML Output of R Markdown with CSS for Print
https://pagedown.rbind.io
Other
889 stars 130 forks source link

another pagedown::html_resume pagebreak issue #170

Closed kevinrue closed 4 years ago

kevinrue commented 4 years ago

Hello.

Thanks a gazillion for the stunning look of pagedown resumes! I'm running into am issue very similar to #153 for both the HTML and PDF versions.

My CV is available here: http://kevinrue.github.io/files/Kevin-Rue-CV.html See the entry "Bioconductor for Genomic Data Science".

The "details" section of this entry, namely:

This course is part of the Genomic Data Science Specialization.

appears on the following page, without respecting the indentation level.

Is there a way to "push" the whole entry to the next page, when it doesn't completely fit at the end of the previous page?

Thanks again!

RLesur commented 4 years ago

Hi @kevinrue,

Glad you like the resume template!

Is there a way to "push" the whole entry to the next page, when it doesn't completely fit at the end of the previous page?

I've fixed that in https://github.com/rstudio/pagedown/commit/affb42f79cf758dd657b72cfbd84bddd483ce813

Please, can you can try with the development version of pagedown and tell me whether the problem is fixed for your resume?
You can install the development version using: 

remotes::install_github("rstudio/pagedown")
kevinrue commented 4 years ago

The fix works perfectly!

It looks flawless to me now. https://kevinrue.github.io/files/Kevin-Rue-CV.html

Thanks a ton! All the best