search

rstudio / pagedown

Paginate the HTML Output of R Markdown with CSS for Print
https://pagedown.rbind.io
Other
894 stars 127 forks source link

Enable SCSS files in the css #244

Closed felipecrp closed 3 years ago

felipecrp commented 3 years ago

This PR fix #243.

I changed the regexp to enable css and scss files.

Best regards, Felipe

felipecrp commented 3 years ago

@yihui Apparently, the error is related to the build process instead of the PR change itself. Can you help me fix it?

yihui commented 3 years ago

@felipecrp We can ignore the Travis error in this case. Thanks!

felipecrp commented 3 years ago

@cderv and @yihui ,

Thank you for the support.

I changed the regexp using the @cderv suggestion and tested the new release with .scss and .sass files. I also updated the roxygen doc, the documentation, and the NEWS.

I think this PR is ready for delivery.

Best regards, Felipe

yihui commented 3 years ago

This is the good practice, right @yihui ?

Yes, let's do that (require rmarkdown >= 2.8).

felipecrp commented 3 years ago

Thank you for the support.