rstudio / pagedown

Paginate the HTML Output of R Markdown with CSS for Print
https://pagedown.rbind.io
Other
894 stars 127 forks source link

Paged-footnotes: Footnote cutoff after certain citations #275

Open paulcbauer opened 2 years ago

paulcbauer commented 2 years ago

We are writing our first journal article with pagedown using paginated footnotes. For some forms of citation in footnotes, the rest of the footnote text is cut off. The example rmd below should reproduce the issue. Thanks for looking into the issue!

---
title: "Issue with citations in footnotes"
shorttitle: "..."
author: "..."
date: '...'
abstract: '...'
keywords: [...]
links-to-footnotes: false
paged-footnotes: true
output: pagedown::jss_paged
knit: pagedown::chrome_print
bibliography: [packages.bib]
---

```{r setup, include=FALSE}
knitr::opts_chunk$set(
    message = FALSE,
    warning = FALSE,
    include = FALSE
)
knitr::write_bib(c("knitr", "rmarkdown", "pagedown"),
                 file = 'packages.bib')

text text text.^[Text after [@R-knitr] citation is shown [@R-knitr]. Text is visible.] text text text
text text text.^[Text after @R-knitr citation is not shown @R-knitr. Text is not visible.] text text text
text text text.^[Text after [@R-knitr; @R-rmarkdown] citation is not shown [@R-knitr; @R-rmarkdown]. Text is not visible.] text text text

\newpage

References

cderv commented 2 years ago

thanks for the report.

here is what I see image

For first too, this is working ok it seems. For last one, the Text is not visible part is not moved into the footnotes and kept in main body.

Seems like some adjustment is required.

paulcbauer commented 2 years ago

Strangely (in contrast to you) I get the issue for both Footnote 2 and 3 even after updating pagedown, rmarkdown and knitr.

Untitled

cderv commented 2 years ago

Can you share your versions ? R , packages and Pandoc ?

paulcbauer commented 2 years ago

Yes. Please find it below:


R version 4.1.2 (2021-11-01) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 17763)

Matrix products: default

attached base packages: [1] stats graphics grDevices utils datasets methods base

loaded via a namespace (and not attached): [1] compiler_4.1.2 fastmap_1.1.0 htmltools_0.5.2 tools_4.1.2 yaml_2.2.1
[6] rmarkdown_2.11 knitr_1.37 pagedown_0.16 xfun_0.28 digest_0.6.29
[11] rlang_0.4.12 evaluate_0.14

cderv commented 2 years ago

Can you share also

rmarkdown::find_pandoc()

thanks

paulcbauer commented 2 years ago

Below. Thank you (I think I haven't updated pandoc in a long time).

$version [1] ‘2.14.0.3’

$dir [1] "C:/Program Files/RStudio/bin/pandoc"

cderv commented 2 years ago

I'll try to reproduce with these information then, Pandoc is at 2.17.1.1 now you can use rstudio daily or install specific pandoc if you want to upgrade, but it should work no matter the version when this is recent enough

cderv commented 2 years ago

So that was helpful. The difference between you and me is indeed the Pandoc version. I can reproduce with 2.14.0.3.

We need to rework the Lua filter probably. Thanks for the report!

paulcbauer commented 2 years ago

Thank you for looking into it!