search

rstudio / pins-python

https://rstudio.github.io/pins-python/
MIT License
52 stars 12 forks source link

typo, line 305, `./pins/boards.py` missing f for f-string #170

Closed hhp94 closed 1 year ago

hhp94 commented 2 years ago

pins version: 0.7.1 python: 3.9.13 os: Ubuntu 22.04 LTS

Thank you so much for your hard work on Pins. I'm so excited about this project. Now I can use {mice} and {missForest} for imputation and my coworkers can run their models using my data in Python!

But yeah, for version 0.7.1 of pins-python, there's a typo on line 305, ./pins/boards.py. It looks like an "f" is missing at the beginning of the error message for the f-string and a comma is missing between the line break?

                raise PinsError(
                    "Attempting to write pin version to {dst_version_path}, "
                    "but that directory already exists."
                )

I got this error when I tried to run pin_write twice very quickly and since the hash is the same and the time difference between the two calls are two small the version became the same and the check probably tripped.

Sincerely, EDIT: added relevant code chunk

machow commented 1 year ago

Thanks for reporting -- should be fixed in latest release! If there's anything else you need to make it easier to work across R and python, definitely let us know! :)

https://github.com/rstudio/pins-python/releases/tag/v0.7.2