search

rstudio / pins-python

https://rstudio.github.io/pins-python/
MIT License
52 stars 12 forks source link

Remove syntax used as a workaround while Python 3.7 was being supported #246

Closed nathanjmcdougall closed 3 months ago

nathanjmcdougall commented 4 months ago

I noticed a few places in the code where there were workarounds associated with Python 3.7. Since support for 3.7 has been dropped, I have refactored to remove these workarounds.

isabelizimm commented 4 months ago

Hmmm.... not sure why the CI isn't showing up here (there a dev branches that is identical to this one and run the tests from there. I think it's mad about the force push, which is a little surprising to me! But, the tests ran, just not reflected here. Sorry about that!) but this fails on Posit Connect, it looks like @functools.cached_property might not be an exact swap from @property.

If you would like, I can pick up the fix for that platform since I have access to that testing environment (probably early next week). But up to you, depending on your willingness to debug that specific platform!

nathanjmcdougall commented 4 months ago

I think I just forgot to access the value ["username"].