search

rstudio / pins-python

https://rstudio.github.io/pins-python/
MIT License
50 stars 12 forks source link

Migrate to pre-commit.ci for pre-commit checks #255

Open nathanjmcdougall opened 2 months ago

nathanjmcdougall commented 2 months ago

Currently the Code Checks workflow is emitting a few warnings.

One of them is the following: Run pre-commit

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-python@v4, pre-commit/action@v2.0.3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The pre-commit/action README has the following message; https://github.com/pre-commit/action

this action is in maintenance-only mode and will not be accepting new features. generally you want to use pre-commit.ci which is faster and has more features.

I think we should consider performing the migration to pre-comit.ci.

nathanjmcdougall commented 2 months ago

I think the first thing is to enable to pre-commit.ci GitHub App: https://[pre-commit.ci](https://pre-commit.ci/)/ It will start working without any config since we have pre-commit-config.yaml

Then, once it's working, a PR can be opened to remove the existing CI step.