Closed nathanjmcdougall closed 2 months ago
Currently omitting a warning when running tests from the root dir:
PytestUnknownMarkWarning: Unknown pytest.mark.fs_file - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
This was my mistake - should be running tests from pins folder with pytest pins rather than pytest .
pins
pytest pins
pytest .
This drew my attention to this section of conftest.py: https://github.com/rstudio/pins-python/blob/70380b4532f3778e4777888507a49c2d1cab1ae8/pins/tests/conftest.py#L94-L100 This is the only place where the BACKEND_MARKS variable is used, so I reckon rather than dynamically creating these registrations, they can just be hardcoded in the pyproject.toml, which already contains configuration for markers, specifically for skip_on_github. https://github.com/rstudio/pins-python/blob/70380b4532f3778e4777888507a49c2d1cab1ae8/pyproject.toml#L5-L11
conftest.py
BACKEND_MARKS
pyproject.toml
markers
skip_on_github
I'd like to move this configuration into the pyproject.toml.
Currently omitting a warning when running tests from the root dir:
This was my mistake - should be running tests from
pinsfolder withpytest pinsrather thanpytest .This drew my attention to this section of
conftest.py: https://github.com/rstudio/pins-python/blob/70380b4532f3778e4777888507a49c2d1cab1ae8/pins/tests/conftest.py#L94-L100 This is the only place where theBACKEND_MARKSvariable is used, so I reckon rather than dynamically creating these registrations, they can just be hardcoded in thepyproject.toml, which already contains configuration formarkers, specifically forskip_on_github. https://github.com/rstudio/pins-python/blob/70380b4532f3778e4777888507a49c2d1cab1ae8/pyproject.toml#L5-L11I'd like to move this configuration into the
pyproject.toml.