rstudio / pins-python

https://rstudio.github.io/pins-python/
MIT License
52 stars 12 forks source link

Tracking Issue - Pyright Compliance #272

Open nathanjmcdougall opened 3 months ago

nathanjmcdougall commented 3 months ago

This is a tracking issue for addressing stricter compliance with pyright. Each issue needs to be considered on a case-by-case basis, in some cases it might be best to keep the rule disabled.

### Tasks
- [ ] `reportArgumentType`: None defaults without None in their type hint, Variety of other issues
- [ ] https://github.com/rstudio/pins-python/issues/291
- [ ] `reportAttributeAccessIssue`: Variety of issues
- [ ] `reportCallIssue`: Passing extra args to the IFileSystem Protocol, Missing overloads for as_df arg in pin_search and pin_versions
- [ ] https://github.com/rstudio/pins-python/issues/304
- [ ] `reportIncompatibleMethodOverride`: Issues with ExtendMethodDoc, RSConnect implementation of the IFileSystem Protocol
- [ ] https://github.com/rstudio/pins-python/issues/276
- [ ] https://github.com/rstudio/pins-python/issues/312
- [ ] `reportMissingImports`: https://github.com/rstudio/pins-python/issues/262#issuecomment-2240875273
- [ ] `reportMissingTypeStubs`: Missing stubs for fsspec: https://github.com/fsspec/filesystem_spec/issues/625, Missing stubs for joblib: https://github.com/joblib/joblib/issues/1516
- [ ] https://github.com/rstudio/pins-python/issues/306
- [ ] `reportOptionalMemberAccess`: RSConnect API _raw_query return type issue, prepare_pin_version unhandled case
- [ ] `reportOptionalSubscript`: RSConnect API _raw_query return type issue, RSConnect implementation of the IFileSystem Protocol
- [ ] `reportPossiblyUnboundVariable`: Mostly False positives arising from fragmented if statements and integer comparisons
- [ ] `reportReturnType`: Variety of issues
- [ ] https://github.com/rstudio/pins-python/issues/308