search

rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
312 stars 63 forks source link

Error / warn on an empty pin publish #415

Closed colearendt closed 3 years ago

colearendt commented 3 years ago

IIRC this was related to #413

If a user publishes a pin that is "empty" or retrieves a pin that is "empty" (i.e. as a result of broken zip behavior), there should be warning / messaging as such. Otherwise, (particularly for non-dataset pins) it can be very tricky to determine what is being retrieved and whether it was what is expected (i.e. if what you expect is a binary object, you do not expect it to be printable anyways).

hadley commented 3 years ago

I think we'll just avoid this upstream. I don't think it's worth retrofitting better behaviour to already broken published pins, we'll just avoiding publishing broken pins in the future. So please file issues when you find a reprex that creates a broken pin.

github-actions[bot] commented 2 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.