rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
312 stars 63 forks source link

Windows filename restrictions #464

Closed jriley-dhsc closed 3 years ago

jriley-dhsc commented 3 years ago

Pinning the following url works in Ubuntu, not in Windows: 'https://api.coronavirus.data.gov.uk/v2/data?areaType=nation&areaCode=E92000001&metric=newAdmissions&metric=newDeaths28DaysByDeathDate&metric=hospitalCases&format=csv

Error is:

Error in curl::curl_fetch_disk(url, x$path, handle = handle) : Failed to open file C:\Users\USERNAME\AppData\Local\Temp\1\Rtmp6D0BIt\file54b838525f09\data?areaType=nation&areaCode=E92000001&metric=newAdmissions&metric=newDeaths28DaysByDeathDate&metric=hospitalCases&format=csv.

Windows doesn't like ? in a filename.

Or am I doing it wrong - is pins not designed to take urls with a question-mark?

jriley-dhsc commented 3 years ago

Ignore this - I've discovered that the github version has fixed this problem, and I was commenting on the CRAN version. Sorry.

github-actions[bot] commented 2 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.