rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
312 stars 63 forks source link

Implement kaggle board with modern api #473

Closed hadley closed 3 years ago

hadley commented 3 years ago

I'm now fundamentally ambivalent about whether or not this is a good idea. There are two major problems:

  1. It would be better build on top of a package that wraps the kaggle API, but kaggler is neither on CRAN nor actively maintained.
  2. There are quite a few impedance mismatches between the pins model and the kaggle model. Competitions are read only, so board_kaggle_competition() can only retrieve data. Datasets can't be deleted, so it's not easy to test. It's not clear whether board_kaggle_dataset() should use kaggle metadata or pins metadata

So overall it feels like this requires quite a lot more thought and it's not worth finishing now. I'll leave the PR open (and maybe get R CMD check passing), but at this point it seems unlikely that kaggle support will be included in pins 1.0.0.

hadley commented 3 years ago

OTOH while pin_read(), isn't that useful, pin_download() still is. OTOOH, while it's nice to be able to easily access kaggle datasets from R, pins isn't exactly the right place for it. OTOOOH I've done most of the work now.

github-actions[bot] commented 2 years ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.