search

rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
312 stars 63 forks source link

Clarify board_rsconnect allows manual authentication #507

Closed smingerson closed 3 years ago

smingerson commented 3 years ago

Mention manual authorization in board_rsconnect(). I don't know if it makes sense to change the function to accept a separate manual option or not. If you think so, I can add something like that.

Closes #508

hadley commented 3 years ago

Yeah, I was actually wondering about this the other day. So if someone else had the same thought, I think it's a good sign it's worth doing 😄. I think "auto" auth would select "manual" if both server and key were supplied, so most of the changes would be to check_auth() and then the docs for board_rsconnect(). Is that clear enough for you to have a go at it?

smingerson commented 3 years ago

Yes it is, I'll take a crack at it in the next couple days.

smingerson commented 3 years ago

I removed rsc_server_envvar(), replacing it with rsc_server_manual(), as that can be used as rsc_server_manual(server, key) or rsc_server_manual(envvar_get("CONNECT_SERVER"), envvar_get("CONNECT_API_KEY"). Let me know if that's satisfactory, I can put back rsc_server_envvar() back in too if you would prefer.

github-actions[bot] commented 2 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.