search

rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
312 stars 63 forks source link

Add test for writing with `board_folder()` ➡️ reading with `board_url()` #662

Closed juliasilge closed 1 year ago

juliasilge commented 1 year ago

Related to #650

This particular test only checks putting the whole path including the version into the URL for board_url(), but let's get this piece reviewed and merged so we have a good strategy for testing this kind of process.

juliasilge commented 1 year ago

@ijlyttle Do you have any feedback for this testing strategy? We'll add more tests like this once we get the manifests added, and board_url() set up to use them.

ijlyttle commented 1 year ago

If I understand right, the idea is to use webfakes as a substitute for rawgithub.

This way, the tests can be included, self-contained in a single pass, rather than pre-populating with a versioned pin for testing board_url()?

Works for me (and I need to read more about webfakes)!

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.