Use environments for Connect content + user caches

rstudio / pins-r

Pin, discover, and share resources

https://pins.rstudio.com

Other

312 stars 63 forks source link

Use environments for Connect content + user caches #667

Closed juliasilge closed 1 year ago

juliasilge commented 1 year ago

Addresses #635

Instead of removing these troublesome caches like #660 was headed for, this PR instead changes these caches over to use environments (instead of files on disk). This means that:

caches will not persist between sessions
caches will only get into a broken state if a big change is made with the server while a user is working with pins from R
caches can be fixed by restarting R
the first time functions are called they will be slow, but subsequent calls will have the same benefits of caching as we have now

juliasilge commented 1 year ago

This idea worked out great IMO @hadley!

machow commented 1 year ago

Just a heads up -- AFAICT one side-effect of this change is that if users restart their R sessions, they'll be unable to access cached RSC pin content without an internet connection. The issue is that already accessed content will be in their on-disk cache, but there will be no mapping back to it :/

(it might be worth letting people access pins via guid in the future to work around? see https://github.com/rstudio/pins-python/issues/79)

juliasilge commented 1 year ago

@machow That is not different than if we turned the cache off via an environment variable or eventually removed the cache altogether, correct? Those were the other options we have been talking about.

I like the idea of using the GUID as an internal bit of metadata.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.