Start transition from `board_rsconnect()` to `board_connect()`

rstudio / pins-r

Pin, discover, and share resources

https://pins.rstudio.com

Other

312 stars 63 forks source link

Start transition from `board_rsconnect()` to `board_connect()` #678

Closed juliasilge closed 1 year ago

juliasilge commented 1 year ago

The product is now officially Posit Connect, so let's move toward a (backwards-compatible) name change.

juliasilge commented 1 year ago

Oh oof, we already have an @keywords internal but exported function called board_connect(). It... connects to a board. 😩

What are our options here?

Rename this internal function
Pick a different name for the new version of board_rsconnect()

juliasilge commented 1 year ago

I am realizing that we don't have evidence that anyone really uses the RStudio addin or the UI viewer, so maybe this can be the motivation to finally take that code out.

juliasilge commented 1 year ago

The above PR #689 made some good headway on this but it did not change args or functions that are related to the rsconnect R package. Whenever that package is rebranded, we can do some more updates.

After looking at this a bit, I currently don't plan to change:

anything related to the legacy Connect board
internal functions that start with rsc like rsc_bundle() or rsc_server()

juliasilge commented 1 year ago

I'm going to close this issue, since we have finished the updates planned for now. When the rsconnect R package is renamed, we will move forward with other changes. 👍

github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.