rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
312 stars 63 forks source link

Remove unused/broken UI and addin functionality #679

Closed juliasilge closed 1 year ago

juliasilge commented 1 year ago

This PR removes/deprecates functions for viewing legacy API pins in the RStudio Viewer pane. Some of these didn't work anymore:

library(pins)
ui_addin_pin_find()
#> Error in `shiny::shinyAppDir()` at pins-r/R/ui_addin.R:10:2:
#> ! No Shiny application exists at the path ""

#> Backtrace:
#>     ▆
#>  1. └─pins::ui_addin_pin_find()
#>  2.   └─shiny::shinyAppDir(system.file("rstudio/shinyaddin", package = "pins")) at pins-r/R/ui_addin.R:10:2
#>  3.     └─rlang::abort(...)

Created on 2022-11-18 with reprex v2.0.2

library(pins)
ui_connection_create()
#> Error in `shiny::shinyAppDir()` at pins-r/R/ui_connection.R:10:2:
#> ! No Shiny application exists at the path ""

#> Backtrace:
#>     ▆
#>  1. └─pins::ui_connection_create()
#>  2.   └─shiny::shinyAppDir(system.file("rstudio/shinycon", package = "pins")) at pins-r/R/ui_connection.R:10:2
#>  3.     └─rlang::abort(...)

Created on 2022-11-18 with reprex v2.0.2

Some of this may still work but would not be a part of typical production or scheduled jobs because these are intended for interactive use only.

juliasilge commented 1 year ago

This will let us move forward with #678 more easily.

juliasilge commented 1 year ago

As far as I can tell from my interactive work and the automated tests, functionality like read/write/list/etc for the legacy API all are unaffected by these changes.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.