search

rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
312 stars 63 forks source link

Revamp `board_url()` to handle manifest files #681

Closed juliasilge closed 1 year ago

juliasilge commented 1 year ago

Related to #661

Closes #650

juliasilge commented 1 year ago

I was having a hard time with the tests until I remembered about is_testing(), as outlined in #640. Turns out, this setup can be a problem for what we want to do internally as well.

juliasilge commented 1 year ago

@ijlyttle do you have time to install this and check it out? Also give me any feedback or thoughts on the code?

ijlyttle commented 1 year ago

Hi @juliasilge - this is great news! I'll go through this today!

juliasilge commented 1 year ago

Thank you again so much @ijlyttle! 🙌

I really appreciate you being willing to put your thoughts down in the draft PR, and for reviewing. It did end up being a fairly significant set of changes so I'm glad we broke it up!

A question for you ❓ Do you think we should add a small vignette outlining how to use the manifest file and then having collaborators download via board_url()? Would you be interested in contributing such a vignette? You could put the webfakes bit in an echo = FALSE chunk and say in words, "and then you serve the board".

ijlyttle commented 1 year ago

It would be my pleasure to contribute such a vignette! If you like, I'll wait for the dust to settle on this PR, then start another PR.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.