search

rstudio / pins-r

Pin, Discover and Share Resources
https://pins.rstudio.com
Other
301 stars 62 forks source link

Make API version in metadata more consistent #741

Closed juliasilge closed 1 year ago

juliasilge commented 1 year ago

Closes #612

This PR makes the API version (currently, possible values are 0 and 1, or it can be absent for old pins) stored in the metadata more consistent, i.e. stored and read as int.

The error message is intended to communicate about the package version (e.g. 1.1.0.9000 right now) to the user. The API stored in the metadata is more like an internal value and the package version is more like an external value. If we ever drastically changed the user-facing API again, we would bump the package version to 2.0.0, api_version to 2, and go from there.

juliasilge commented 1 year ago

If we ever did need to compare the API version to the package version, we could use compareVersion().

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.