search

rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
312 stars 63 forks source link

Add Google Drive board #749

Closed juliasilge closed 1 year ago

juliasilge commented 1 year ago

Closes #728

Wow, using Google Drive for this is not speedy 😳

juliasilge commented 1 year ago

We should definitely not run the tests for board_gdrive() in CI; they take basically INFINITY amount of time. We also run the tests for board_ms365() only locally, and the use of Microsoft OneDrive is equivalent in many ways to Google Drive here.

juliasilge commented 1 year ago

Any hope of speeding it up by caching drive ids somewhere?

I don't believe so. There's no "extra" mapping between drive ID and something else that we can cache somewhere (like the Connect mappings from GUID to content name).

Just for clarity here, the normal pins caching mechanism does work as expected here, so you don't re-download pin content if it hasn't changed. However, even the process of looking up the pin metadata to check this feels sluggish.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.