search

rstudio / pins-r

Pin, Discover and Share Resources
https://pins.rstudio.com
Other
301 stars 62 forks source link

Test pins with latest version of paws.common 0.6.0 #778

Closed DyfanJones closed 10 months ago

DyfanJones commented 10 months ago

Hi all,

I am in the process in releasing the latest version of paws.common 0.6.0 https://github.com/paws-r/paws/issues/657. paws.common 0.6.0 comes with a new xml parser that has increased performance: https://github.com/paws-r/paws/pull/621. However I am going around all paws dependent packages to ensure the new xml parser doesn't break any existing code.

Is it possible to run your existing tests with the latest version of paws.common 0.6.0? If not please let me know how to set up my environment so that I can test these changes on your behalf.

To install paws.common 0.6.0 you can use r-universe:

install.packages('paws.common', repos = 'https://paws-r.r-universe.dev')
juliasilge commented 10 months ago

Great news about the new parser and yep, I am happy to do this! We typically use revdepcheck for this kind of task, but the situation is a little bit trickier here because the AWS tests only actually run (really read/write to S3) if you have specific env vars set and a specific bucket.

juliasilge commented 10 months ago

I tested locally and in #779 and both look good to go (specifically see the check-boards action); you can consider pins all set. ✅

DyfanJones commented 10 months ago

@juliasilge thanks for the testing. I will close this ticket :)

github-actions[bot] commented 9 months ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.