search

rstudio / pins-r

Pin, Discover and Share Resources
https://pins.rstudio.com
Other
301 stars 62 forks source link

Fix how `board_gdrive()` uses dribble components #782

Closed juliasilge closed 10 months ago

juliasilge commented 10 months ago

Closes #781

When I first put together the support for the Google Drive board, I did not pay enough attention to what is guaranteed to come in a dribble object: https://googledrive.tidyverse.org/reference/dribble.html

This PR addresses this more holistically than #780, throughout all the methods. I don't think I want to change my general testing strategy, but I did just locally run through this (after running devtools::load_all()):

my_dribble <- googledrive::as_dribble("https://drive.google.com/drive/u/1/folders/1GQ-JuG4pT1AK9VLz9UZptnO73H7zDaUe")
board <- board_gdrive(my_dribble)
test_api_basic(board)
test_api_versioning(board)
test_api_meta(board)

All these tests pass and I expect this to now work much better.

github-actions[bot] commented 9 months ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.