Closed michaelhogersnplm closed 1 year ago
Ah yep, I can see how that would be confusing in this situation. They are separate and different tag-like entities.
tags
argument is a pins-specific thing that can be used across all backends, and it can only take a character vector like c("value1", "value2")
.Tagging
for an S3 board, that gets passed through the dots of pin_write()
to S3. This only works for S3 and it needs to be like "key1=value1&key2=value2"
.If you want to have your Tagging
values also show up as pins tags, you would need to do something like this:
board %>% pin_write(mtcars, Tagging = "key1=value1&key2=value2", tags = c("value1", "value2"))
It's a bit unfortunate that the names (S3-specific and pins-specific) of these are so similar. 😕 Maybe we can improve the documentation to be less confusing.
Hi @juliasilge thank you for the quick response! I think for pin_write
the tagging logic works as expected (in that case I was only using the tags
argument which would result in pin::pin_meta
working as expected and the S3 tags looking correct), but when using pin::pin_upload
I can only use the Tagging
argument, tags
is not available it seems. I just happen to be writing some test logic around the object tags for both methods
Ah yep, great point! I outlined what we need to check in #805; take a look if you like and share any other thoughts. 👍
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
Hi there,
Thank you for this package, it is very useful and I noticed something that could possibly be a bug in the pins/paws interaction.
Following the example from https://pins.rstudio.com/reference/board_s3.html, the use of
Tagging
results in objects being correctly tagged in AWS S3, however when usingpins::pin_meta
thetags
entry isNULL
.This only happens when using the
Tagging
argument (for bothpin_write
andpin_upload
), when using thetags
argument forpin_write
(which is not available forpin_upload
) it is possible to correctly retrieve the tags metadata usingpins::pin_meta
.It does not seem related to permissions, as using
paws::s3
and thens3::get_object_tagging
allows to retrieve the tag set via theTagging
argument.I am referring to the following example:
(pins version 1.2.2)
Best, Michael