Closed juliasilge closed 7 months ago
Error message reads much better ... I can't promise I'll read it :)
... but I read the previous one - so there's hope!
I'd guess there was "guessing" the code could have done in the connect_url case - e.g. looking for a file extension, detecting the html response, etc... but I agree that'd be overkill for the case where the user (me!) had typed the url wrong :+1:
Thanks!
Most of the basic URL parsing tools out there (urltools::url_parse()
and httr::parse_url()
) don't really give us directly what we'd need to distinguish between use cases, so I do think it's better to improve the error message rather than try for more guessing.
I appreciate the report a lot -- thanks again! 🙌
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
Closes #810
We now see a message like this when we end up in a bad URL situation, such as trying
pin_read()
on a full path or forgetting a trailing slash for a vanity URL:Created on 2023-11-17 with reprex v2.0.2
@slodge do you have any feedback on this?