search

rstudio / pins-r

Pin, discover, and share resources
https://pins.rstudio.com
Other
316 stars 62 forks source link

Can't enable cache on local board #840

Open wklimowicz opened 2 months ago

wklimowicz commented 2 months ago

First off, thanks for your work on this package!

I'm in the same situation as #669, where I want to enable caching for a slow network drive. The two functions suggested in #669 create a board, and create a folder inside ~/.cache/pins/, but the cache doesn't populate with any files. I've created a reprex repo here with a GitHub action showing that no file get's created after pin_read. Am I misunderstanding when the caching is intended to happen?

https://github.com/wklimowicz/pins-bug-no-cache/

image

juliasilge commented 2 months ago

Oh yes, you are definitely right. Adding a cache path to the board isn't the only thing that needs to happen. What I said here about this just working is definitely wrong. I'm not sure why I thought that. Apologies to both you and the original poster!

Instead, what we would need to do is to set up board_folder() to act more like board_url(), for example, the caching that is implemented in http_download() here: https://github.com/rstudio/pins-r/blob/58082a377d682a48eb370e2d8b45588d0d118127/R/board_url.R#L326

I'll mark this as a feature request once more and we can again collect feedback on it. Thanks for your understanding!