search

rstudio / promises

A promise library for R
https://rstudio.github.io/promises
Other
198 stars 19 forks source link

minor pkgdown issues #15

Open trestletech opened 6 years ago

trestletech commented 6 years ago
screen shot 2018-03-13 at 9 25 01 am
  1. As shown above, when on a learning tab, the Home and Learning tabs are both highlighted as active.
  2. In Firefox 58.0.1, you get a warning about insecure assets. It looks like this is due to a tidyverse SVG getting loaded over HTTP.

(Subjective) 3. In https://rstudio.github.io/promises/articles/overview.html#accessing-results-with-then, it wasn't clear to me what package has the then function. You were just referencing the future() function from another package and then jumped into then. I wasn't clear whether that was also part of the future package or if that's in promises.

jcheng5 commented 6 years ago

@hadley Do you know anything about the Home and Learning tabs both being highlighted? When I first created my pkgdown site, I noticed that pkgdown.r-lib.org itself had the same problem, so I didn't do anything about it--but now pkgdown.r-lib.org is fixed, but rebuilding my site with a new pkgdown install from master didn't fix it.

hadley commented 6 years ago

It should've been fixed in https://github.com/r-lib/pkgdown/commit/c338f4d5dbb8bdccc4dd22e0765488417af4e767#diff-47b9064bcd207a0dff4069ec13f9b521 - but TBH my js is pretty poor so my analyses and fix might be completely wrong.