Closed stefanoborini closed 4 years ago
Hi there!
It's not true that the event loop is blocked while a promise is pending. That really would be pretty useless 😅
However to try to avoid forcing the app author to deal with race conditions, within a single session we suspend I/O with the browser until all pending promises have completed. While this does affect the kind of thing you're trying to do, it at least lets multiple sessions make progress simultaneously.
If you know what you're doing (and it sounds like you do!) then you can opt out of this session-level synchronization with a technique I posted in a comment on this issue: https://github.com/rstudio/promises/issues/23
Ok, thank you. On the internal design, just to understand, is there a single event loop handling all sessions, or each session gets its own loop on a separate thread/process?
I think I get the overall design now. In python terms, it's more like tornado, rather than flask.
There's a single event loop handling all sessions. The event loop itself is never suspended. When Shiny sessions have pending promises (that they know about) they just set a flag on themselves to queue input/output until the flag is unset.
@jcheng5 and I assume that Shiny learns about the pending futures because the server function returns them? If that's the case, as it seems to be from other posts that return NULL from the server function, how is it achieved that with "fire and forget" futures the then() function actually executes in the main thread? to do so,
It's quite impressive as a design, but there's a lot of magic happening and I am trying to understand it better.
Sorry for the months-late reply, I missed your comment until now.
The logic you're interested in is here: https://github.com/rstudio/promises/blob/9ebad6dad529d53e2fed2fc4c4bed354edb540ed/R/promise.R#L422-L456
Essentially, when then()
is called on a Future object, the Future is cast to a Promise, and this as.promise.Future
method uses the later
package to poll against the completion of the Future.
I've just recently stumbled upon this thread while trying to wrap my head around Shiny and Plumber's auto-magical handling of Future objects. One piece that I'm stuck on is how later::later(check, poll_interval)
ever runs check()
when called from within a running Shiny or Plumber program (as opposed to being in R's standard REPL). The documentation says:
To avoid bugs due to reentrancy, by default, scheduled operations only run when there is no other R code present on the execution stack; i.e., when R is sitting at the top-level prompt. You can force past-due operations to run at a time of your choosing by calling
run_now()
.
Once Shiny enters its main event loop, isn't there always R code present on the main execution stack? That is, the loop code itself is currently executing, and so I'm struggling to figure out how the later::later
-registered function (check
, here) ever runs.
I've searched for the workaround run_now()
being called as part of that loop (which in this case would then serve the role of the Future completion polling step), but run_now()
doesn't seem to actually be used anywhere.
Clearly I'm missing something w.r.t. R's handling of background tasks ... perhaps there's a more in-depth guide somewhere on the scheduling internals of later and promises?
@mmuurr You’re right, this appears to be a paradox. It works because when shiny or plumber are blocking the console, it’s actually httpuv::service that’s repeatedly being called in a while loop, and httpuv::service calls later::run_now.
@jcheng5, great, thanks for the tip there ... I now see that httpuv::service
is really just a wrapper on later::run_now
. If I'm reading the code correctly, httpuv runs separately from the main R call stack (thread) and as it handles each request pushes them to later's queue, which is then popped by Shiny/Plumber calling httpuv::service()
in their own console-blocking 'main' loop. Is that a fair (and obviously over-simplified) characterization?
BTW -- in this Shiny code line found here:
timeout <- max(1, min(maxTimeout, timerCallbacks$timeToNextEvent(), later::next_op_secs()))
... are units being mixed incorrectly?
timeout
is passed in to httpuv::service
which takes milliseconds;maxTimeout
appears to be set to milliseconds;timerCallbacks
appears to manage all of its times in milliseconds;later::next_op_secs()
, however, appears to be returning the time to the next ready-to-run expression in seconds.I think you might be right about the mixed units, it looks like that code was written carefully and then refactored less carefully (by me). If you happen to feel inclined to submit a PR, I’m sure @wch would appreciate it!
re: units; will do.
Thanks for the dialog; very helpful!
Sorry this is more of a question rather than an issue, but I could not get a definitive answer on other channels.
I am experienced with React and async under python. I am new to the world of R and Shiny.
I noticed from the documentation that a future must be completed when the iteration of the event loop is completed. There's thus the equivalence of a synchronization barrier that does not let the event loop proceed further in parsing events until all the future are resolved.
My question is: what is the final advantage of using an async approach in shiny? If I have a process that can take, say, up to two minutes (e.g. a network request timeout, or a heavy calculation), the event loop will be unable to process any further input for those two minutes. The only possible advantage is if multiple futures are spawned.
My goal is to replace HTML elements before and after an async operation, but it's a testbed for training in Shiny, not an actual problem I have to solve. I am not therefore looking for a workaround or solution, rather to understand the general concepts and preferred approaches.
Thanks