search

rstudio / quillt

A pkgdown template for the R Markdown Ecosystem
https://pkgs.rstudio.com/quillt
Other
27 stars 8 forks source link

Change style for inline code in headers #25

Closed cderv closed 3 years ago

cderv commented 3 years ago

This fixes #24

I added an article to test some specific styling that we change

cderv commented 3 years ago

Here is what we get with this change: https://deploy-preview-25--quillt.netlify.app/articles/articles/test-style.html

apreshill commented 3 years ago

This looks great (and having a deploy preview is so so great).

Do you think for H3 we should not capitalize the code in the header? Or would that look odd as lowercase?

Screen Shot 2021-03-11 at 8 45 29 AM
cderv commented 3 years ago

Or would that look odd as lowercase?

This maybe would look odd with part of the tile upper case and other note... 🤔

Or maybe not: image

All the headers: image

cderv commented 3 years ago

Looking at all the header at the same time, it maybe better to not force inline code upper case.

And also because code is case sensitive... camelCase would be bad with this theme I guess. right ?

apreshill commented 3 years ago

True, we should probably make all code text-transform: none?

apreshill commented 3 years ago

I think that looks about as good as it can get! It appears downlit linking isn't activated until you get down to h6, but that is not a bad thing here.

gadenbuie commented 3 years ago

Thanks for the quick fix @cderv and @apreshill!