use_quillt_pkgdown() should add the vignette infrastructure too - Githubissues

rstudio / quillt

A pkgdown template for the R Markdown Ecosystem

https://pkgs.rstudio.com/quillt

Other

27 stars 8 forks source link

use_quillt_pkgdown() should add the vignette infrastructure too #37

Open cderv opened 3 years ago

cderv commented 3 years ago

I think from https://github.com/rstudio/rticles/pull/412 as some files were missing (https://github.com/rstudio/rticles/pull/412/commits/8f81237c23aabf2e713833f3e65eea5536162fb8) that use_quillt_pkgdown() is not complete.

As we are creating the vignette from a template https://github.com/rstudio/quillt/blob/f6c6729a389419d3964f1e0fcfd14ac610e9c541/R/templates.R#L93-L97

we don't use usethis::use_vignette(), which leads to missing part in the package when no vignettes are already there.

This should be improved.