search

rstudio / quillt

A pkgdown template for the R Markdown Ecosystem
https://pkgs.rstudio.com/quillt
Other
27 stars 8 forks source link

Update footer.html #7

Closed maelle closed 3 years ago

maelle commented 3 years ago

This would fix the regression observed by @cderv I think but I am missing some subtleties of why you were using this syntax.

maelle commented 3 years ago

Was it to let people override the footer?

cderv commented 3 years ago

let's try !

maelle commented 3 years ago

with pkgdown dev version there's always a footer variable passed to the footer template, it has both a left and a right component. I am very sorry!

cderv commented 3 years ago

This is the same in tidytemplate FWIW: https://github.com/tidyverse/tidytemplate/blob/b819e3028b4b9342aeac238de147821bbb4c517c/inst/pkgdown/templates/footer.html#L2

cderv commented 3 years ago

I confirm this fix the issue. @apreshill do you know if this would be ok to change like ? What was it to specify a footer directly from the yaml file ? We may need that if quillt is to be used by others too, so that they can overwrite the footer.

cderv commented 3 years ago

It seems like the last change works too. This is a hidden trick from whisker !

apreshill commented 3 years ago

Should I merge this in? Is it ready for review or WIP?