search

rstudio / r-system-requirements

System requirements for R packages
MIT License
122 stars 21 forks source link

Add support for Debian 10 and Debian unstable #118

Closed gaborcsardi closed 1 year ago

gaborcsardi commented 1 year ago

Mostly straightforward, I only had to modify one rule.

gaborcsardi commented 1 year ago

👍, the CI failure is an unrelated issue with openSUSE

Actually, do you mind if I change the tests to update the metadata only once? That would make them much faster I think and these failures would probably go away.

gaborcsardi commented 1 year ago

@glin oh, and thanks for the review!

glin commented 1 year ago

Hmm, could do we do that while still running every rule test in a clean container? Each rule runs in a fresh container to prevent previously installed repos from messing with subsequent tests. Maybe we could have GHA build an image with updated metadata without cleaning on every run, then remove the metadata update from the tests.

The tests used to update metadata once, but there were bugs that slipped through because of that (#115)

gaborcsardi commented 1 year ago

Maybe we could have GHA build an image with updated metadata without cleaning on every run, then remove the metadata update from the tests.

Yeah, exactly.