Closed glin closed 2 months ago
cc @jeroen for review
Thanks for debugging this, LGTM!
I personally think this regex overcomplicates it really, why not just use /poppler/i
. The only edge cases I can think of is that this may install this c++ library also for R packages that uses other poppler tools, which is harmless.
Yeah, that was exactly why since we recently added a rule for poppler-glib that only applied to Rpoppler. While poppler-cpp only applied to pdftools. There was no other package that only specified "poppler". https://github.com/rstudio/r-system-requirements/pull/179
OK great, I confirm this fixed the CI of pdftools!
\b
word boundaries don't apply if the end of the word is a character like+
.\B
matches non-word boundaries, but we don't really need any boundary here.