schloerke commented 5 years ago

Merge logic of ignoring consecutive "async start/stop followed by and idle step" and idle steps
Fix hidden step number
When labels of nodes that can't be found, display the react id, not "".
When value for a node that can't be found, display the actual value.

jcheng5 commented 5 years ago

Make sure to add testing notes please!

schloerke commented 5 years ago

Testing Notes

remotes::install_github("rstudio/shiny@rc-v1.3.0")
remotes::install_github("rstudio/reactlog#30")
options(shiny.reactlog = TRUE)

shiny::runExample("01_hello")

Open two tabs of the application.
Adjust the bar a few times on the 1st tab.
On the first tab, hit Cmd + Fn + 4
On the second tab, adjust the bar a few times
On the first tab, hit Cmd + Fn + 4, then adjust the bar a few times.
Open the reactlog on the first tab. (Cmd + Fn + 3)

In the reactlog, verify there are hidden steps between the two user marks by holding the Shift key and using the arrow keys to traverse the hidden steps.

rstudio / reactlog

Minor bugs for the status bar #30

Testing Notes