search

rstudio / rscloud

Managing RStudio Cloud spaces with R
https://rstudio.github.io/rscloud
Other
22 stars 11 forks source link

Transition generic endpoint to more specific one. #52

Closed ssinnott closed 2 years ago

ssinnott commented 2 years ago

This transitions the space projects call to a new set of endpoints that are more optimized for handling requests for projects in a space.

This also tweaks a spot in the space serialization where the name of the count has changed.

ssinnott commented 2 years ago

Found it (I think). This seems to work locally but I still see the tests are failing here.

==> Testing R file using 'testthat'

ℹ Loading rscloud
Using `user_id` column.
Using `user_id` column.

══ Testing test-projects.R ═════════════════════════════════════════════════════

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 0 ]
[ FAIL 1 | WARN 0 | SKIP 0 | PASS 0 ]
[ FAIL 1 | WARN 0 | SKIP 0 | PASS 1 ]

── Failure (test-projects.R:9:3): project listing works ────────────────────────
`projs` (`actual`) not identical to c("test-project-1", "test-project-2") (`expected`).

`actual`:   "test-project-2" "test-project-1"
`expected`: "test-project-1" "test-project-2"

[ FAIL 1 | WARN 0 | SKIP 0 | PASS 1 ]

Test complete
mine-cetinkaya-rundel commented 2 years ago

I think the test failures are the same issue as before so we'll need to tend to them later, but doesn't need to hold this PR up.