rstudio / rsconnect-jupyter

Publish Jupyter notebooks to RStudio Connect
GNU General Public License v2.0
25 stars 6 forks source link

add env-vars argument to deploy method #326

Closed kgartland-rstudio closed 2 years ago

kgartland-rstudio commented 2 years ago

env-vars has been introduced on the master rsconnect-python branch. Prior to the rsconnect-python release we will need to add a new env-vars parameter to rsconnect-jupyter deploy method.

Currently when deploying with the latest rsconnect-jupyter plugin and the master branch of rsconnect-python the following error is thrown:

[E 15:25:08.652 NotebookApp] Uncaught exception POST /rsconnect_jupyter/deploy (192.168.86.38)
    HTTPServerRequest(protocol='http', host='kevins-mbp.lan:9999', method='POST', uri='/rsconnect_jupyter/deploy', version='HTTP/1.1', remote_ip='192.168.86.38')
    Traceback (most recent call last):
      File "/Users/kgartland/.pyenv/versions/3.8.2/envs/rsconnect-tag/lib/python3.8/site-packages/tornado/web.py", line 1702, in _execute
        result = method(*self.path_args, **self.path_kwargs)
      File "/Users/kgartland/.pyenv/versions/3.8.2/envs/rsconnect-tag/lib/python3.8/site-packages/tornado/web.py", line 3173, in wrapper
        return method(self, *args, **kwargs)
      File "/Users/kgartland/.pyenv/versions/3.8.2/envs/rsconnect-tag/lib/python3.8/site-packages/rsconnect_jupyter/__init__.py", line 198, in post
        retval = api_client.deploy(app_id, nb_name, nb_title, nb_title is not None, bundle)
    TypeError: deploy() missing 1 required positional argument: 'env_vars'
[W 15:25:08.661 NotebookApp] Unhandled error
[E 15:25:08.661 NotebookApp] {
      "Host": "kevins-mbp.lan:9999",
      "Connection": "keep-alive",
      "Content-Length": "582",
      "Accept": "*/*",
      "X-Requested-With": "XMLHttpRequest",
      "X-Xsrftoken": "2|7e3f6017|bf7a8ec5d9381849d6d6f6d285dac2c1|1651257438",
      "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36",
      "Content-Type": "application/json",
      "Origin": "http://kevins-mbp.lan:9999",
      "Referer": "http://kevins-mbp.lan:9999/notebooks/stock-report-jupyter.ipynb",
      "Accept-Encoding": "gzip, deflate",
      "Accept-Language": "en-US,en;q=0.9",
      "Cookie": "_xsrf=2|7e3f6017|bf7a8ec5d9381849d6d6f6d285dac2c1|1651257438"
    }
[E 15:25:08.661 NotebookApp] 500 POST /rsconnect_jupyter/deploy (192.168.86.38) 78.730000ms referer=http://kevins-mbp.lan:9999/notebooks/stock-report-jupyter.ipynb

The above error was hit using the following versions:

rsconnect-jupyter server extension version: 1.5.0
rsconnect-jupyter nbextension version: 1.5.0
rsconnect-python version:1.7.2.dev117+gcc1aaef