search

rstudio / rsconnect-jupyter

Publish Jupyter notebooks to RStudio Connect
GNU General Public License v2.0
25 stars 6 forks source link

Rebranding #331

Closed whimsicallyson closed 1 year ago

whimsicallyson commented 1 year ago

Description

Updates company name and grammar throughout. Additionally, adds CSS and header/footer overrides to docs in order to match other docs on the site. Updated screenshots in the docs as well.

Leaves historical references to RStudio Connect in NEWS intact.

Also not sure if I should loop any non-Content Engagement folks into these reviews? 🤷‍♀️

Connected to https://github.com/rstudio/connect/issues/21954

Testing Notes / Validation Steps

I'd recommend attempting to deploy a Jupyter notebook to Connect to make sure all relevant references to RStudio are switched to Posit, and building the docs and comparing the styling to docs.rstudio.com

whimsicallyson commented 1 year ago

@mmarchetti I added you to this review so that someone who has been involved with the rsconnect-jupyter repo in the past can take a look. If that's not you, let me know who I should tag instead!

whimsicallyson commented 1 year ago

note: there's a video here that I don't know anything about updating....

nkakade-rstudio commented 1 year ago

Found one instance of RStudio Connect in the docs:

Screen Shot 2022-10-11 at 12 50 08 PM
whimsicallyson commented 1 year ago

@nkakade-rstudio I haven't been updating release notes/NEWS/similar things that are tied to a specific version, because it was still RStudio Connect whenever it was written!

nkakade-rstudio commented 1 year ago

The changes on this PR are verified. Verified locally with rsconnect-jupyter build running.

whimsicallyson commented 1 year ago

@Lytol linting issue I mentioned in our content engagement meeting