rstudio / rsconnect-jupyter

Publish Jupyter notebooks to RStudio Connect
GNU General Public License v2.0
25 stars 6 forks source link

Create Manifest workflow in jupyter is broken with rsconnect-python 1.9+ #334

Closed kgartland-rstudio closed 1 year ago

kgartland-rstudio commented 1 year ago

When using the Create Manifest option in the rsconnect-jupyter UI with rsconnect-python>=1.9.0 an unhandled error is thrown:

[E 10:15:30.101 NotebookApp] Uncaught exception POST /rsconnect_jupyter/write_manifest (127.0.0.1)
    HTTPServerRequest(protocol='http', host='127.0.0.1:9999', method='POST', uri='/rsconnect_jupyter/write_manifest', version='HTTP/1.1', remote_ip='127.0.0.1')
    Traceback (most recent call last):
      File "/Users/kgartland/.pyenv/versions/3.8.2/envs/rsconnect-tag/lib/python3.8/site-packages/tornado/web.py", line 1711, in _execute
        result = method(*self.path_args, **self.path_kwargs)
      File "/Users/kgartland/.pyenv/versions/3.8.2/envs/rsconnect-tag/lib/python3.8/site-packages/tornado/web.py", line 3208, in wrapper
        return method(self, *args, **kwargs)
      File "/Users/kgartland/.pyenv/versions/3.8.2/envs/rsconnect-tag/lib/python3.8/site-packages/rsconnect_jupyter/__init__.py", line 266, in post
        created, skipped = write_manifest(relative_dir, nb_name, Environment(**environment_dict), output_dir)
    TypeError: write_manifest() missing 2 required positional arguments: 'hide_all_input' and 'hide_tagged_input'
[W 10:15:30.104 NotebookApp] Unhandled error

It looks like jupyter is expecting both hide_all_input and hide_tagged_input to be included in the call. There is currently no way to Create Manifest with those fields in the rsconnect-jupyter UI.