search

rstudio / rsconnect

Publish Shiny Applications, RMarkdown Documents, Jupyter Notebooks, Plumber APIs, and more
http://rstudio.github.io/rsconnect/
129 stars 79 forks source link

tests against "real" projects are skipped on CRAN #1010

Closed aronatkins closed 9 months ago

aronatkins commented 9 months ago

Avoid (revdep) test situations where a test project has a dependency that may be installed from source. We encountered this first with curl, but could occur with any package required by content (e.g. Shiny, Plumber).

The now-skipped tests were identified by installing shiny, plumber, rmarkdown, and https://github.com/jeroen/curl from source and then running tests. Each failing test (caused by renv snapshot failures related to from-source installs) was marked for CRAN skipping.

aronatkins commented 9 months ago

I don't love that we are adding skip_on_cran() to more and more tests, but don't see an alternative.

kevinushey commented 9 months ago

FWIW in renv I avoid these sorts of issues by only using a local CRAN-like repository with dummy packages, and avoiding whatever the current state of CRAN might be.

aronatkins commented 9 months ago

Chatted with @kevinushey - we're going to skip-tests for now.