rstudio / rsconnect

Publish Shiny Applications, RMarkdown Documents, Jupyter Notebooks, Plumber APIs, and more
http://rstudio.github.io/rsconnect/
134 stars 82 forks source link

Unit test bugs with dockerized Connect #195

Closed scottmmjackson closed 1 year ago

scottmmjackson commented 7 years ago
Failed -------------------------------------------------------------------------
1. Error: Users API (@test-connect.R#37) ---------------------------------------
invalid 'text' argument
1: connectClient(server$url, list()) at .../tests/testthat/test-connect.R:37
2: parseHttpUrl(service) at .../rsconnect/R/connect.R:42
3: regexec("(http|https)://([^:/#?]+)(?::(\\d+))?(.*)", urlText) at .../rsconnect/R/http.R:201

It looks like getDefaultServer isn't playing well when Connect is running in docker rather than directly on the host. isConnectRunning returns true because a ps -a shows connect's process running in docker.

hadley commented 1 year ago

Closing, since that test file has obviously changed in the last 5+ years 😆