search

rstudio / rsconnect

Publish Shiny Applications, RMarkdown Documents, Jupyter Notebooks, Plumber APIs, and more
http://rstudio.github.io/rsconnect/
134 stars 82 forks source link

deployDoc and deploySite do not include the quarto version #885

Closed samperman closed 1 year ago

samperman commented 1 year ago

Note, this testing was done when deploying to Posit Cloud

If I run rsconnect::deployDoc or rsconnect::deploySite, the resulting manifest does not include the quarto version used. However, if I use rsconnect::writeManifest the resulting manifest does include the quarto version.

For cloud to do the right thing, it will need to know the version of quarto.

aronatkins commented 1 year ago

@samperman - could you capture the version of rsconnect that you used to test? Quarto handling has changed since the 0.8.29 CRAN release. Does the development version behave differently?

hadley commented 1 year ago

I think this is possibly a "bug" in writeManifest() because it doesn't set isCloudServer correctly: https://github.com/rstudio/rsconnect/blob/description-manifest/R/bundle.R#L201-L203

samperman commented 1 year ago

this testing was all done with rsconnect from github

aronatkins commented 1 year ago

Cloud had never needed the Quarto version before; this feels like a new requirement. That said, removing the isCloudServer checks the manifest-creation workflow means that the manifest is agnostic to the deployment target.

@samperman - can posit.cloud and shinyapps.io both cope with the existence of a quarto sub-document in the manifest.json?

samperman commented 1 year ago

good question. its likely that they do not support it in all cases right now, but if it makes things consistent, i can make sure we add support so things work if its there or not.

aronatkins commented 1 year ago

Thanks. I think we'll want that addressed before merging #886. In the meantime, you could test with that branch to confirm it produces data you can handle.

samperman commented 1 year ago

sounds good. i'll update this ticket once that support is in place. thanks!