search

rstudio / rsconnect

Publish Shiny Applications, RMarkdown Documents, Jupyter Notebooks, Plumber APIs, and more
http://rstudio.github.io/rsconnect/
131 stars 79 forks source link

renv dependency limit mirrors the rsconnect bundle limit #969

Closed aronatkins closed 11 months ago

aronatkins commented 11 months ago

additionally, do not let renv infer the root.

fixes #968

aronatkins commented 11 months ago

Note: We probably uncovered the same root = NULL problem in packrat and worked around it by providing the project path as the root directory. https://github.com/rstudio/packrat/blob/ac6bc33bce3869513cbe1ce14a697dfa807d9c41/R/dependencies.R#L182

aronatkins commented 11 months ago

@kevinushey - Any theories about why the Windows release tests are failing? It appears to be enumerating files, which isn't present on the other OSes.

kevinushey commented 11 months ago

Maybe we need progress = FALSE in the call to dependencies()?

kevinushey commented 11 months ago

For reference, renv has a progress reporter that only prints progress if the associated action takes a "long" time (more than 1 second). It's started here:

https://github.com/rstudio/renv/blob/ac7126d7b2856a39012d6079689861b18c07c5b7/R/dependencies.R#L477-L481

And see the progress helpers here:

https://github.com/rstudio/renv/blob/ac7126d7b2856a39012d6079689861b18c07c5b7/R/progress.R#L2-L32

aronatkins commented 11 months ago

Thanks. It's probably progress. There is no option to control that in CI-only, correct?

aronatkins commented 11 months ago

Also: We made the same progress = FALSE change in the packrat call to renv::dependencies()... same lessons. :)

kevinushey commented 11 months ago

There is no option to control that in CI-only, correct?

Right, unfortunately there's no option.