rstudio / rsconnect

Publish Shiny Applications, RMarkdown Documents, Jupyter Notebooks, Plumber APIs, and more
http://rstudio.github.io/rsconnect/
131 stars 79 forks source link

Implement envManagement args for `::writeManifest()` #978

Closed dbkegley closed 10 months ago

dbkegley commented 11 months ago

Closes #977

Adds the following args for all commands that write bundle manifests

QA:

# writes a manifest with environment.environment_management.r and environment.environment_management.python = false
rsconnect::writeManifest(..., envManagement=FALSE)

# writes a manifest with environment.environment_management.r and environment.environment_management.python = true
rsconnect::writeManifest(..., envManagement=TRUE)

# writes a manifest with environment.environment_management.r = true
# environment.environment_management.python is not defined
rsconnect::writeManifest(..., envManagementR=TRUE)

# writes a manifest with environment.environment_management.python = true
# environment.environment_management.r is not defined
rsconnect::writeManifest(..., envManagementPy=TRUE)

# writes a manifest with environment.image = "my/image:latest"
# environment.environment_management is not defined
rsconnect::writeManifest(..., image="my/image:latest")
ChaitaC commented 10 months ago

Verified on branch

RemoteSha: 382e35b0e265b8c23314cef7fe4384267f96a9f5
GithubRepo: rsconnect
GithubUsername: rstudio
GithubRef: kegs-env-management
ChaitaC commented 10 months ago

@dbkegley minor nit: envMangementR and envManagementPy does not say Posit Connect vs envManagement description says Posit Connect

Screenshot 2023-08-28 at 4 32 08 PM Screenshot 2023-08-28 at 4 32 47 PM Screenshot 2023-08-28 at 4 32 41 PM Screenshot 2023-08-28 at 4 32 29 PM