rstudio / rstudio

RStudio is an integrated development environment (IDE) for R
https://posit.co/products/open-source/rstudio/
Other
4.68k stars 1.09k forks source link

Keyboard short cut Ctrl+shift+F8 on linux does not insert citation and zooms the presentation tab #10027

Closed astayleraz closed 2 years ago

astayleraz commented 2 years ago

System details

RStudio Edition : <!-- Server -->
RStudio Version : 2022.01.1-daily-171.pro1
OS Version      : Ubuntu
R Version       : 

Steps to reproduce the problem

Automation failure: https://build.rstudioservices.com/job/IDE/job/qa-opensource-automation/903/testReport/rstudio_server_pro.tests.test_Citations/TestCitations/test_no_duplicate_citations/

Note: This was not an issue in 2021.12.0-daily+64.pro1 and the test was passing on this build. Not sure if this might be related to the work done in shortcuts in https://github.com/rstudio/rstudio/issues/9915

Test steps:

  1. Create a markdown file in a ubuntu or linux instance.
  2. Go into visual mode.
  3. Use hotkey to insert citation (Ctrl+shift+F8)

Describe the problem in detail

Actual: Zooms the presentation tab.

Looking at the modify keyboard shortcuts modal it looks like zoom presentation was newly added and shares the same hotkeys as insert citation.

Screen Shot 2021-10-29 at 2 11 51 PM

Screen Shot 2021-10-29 at 2 12 19 PM

Describe the behavior you expected

Expected: Should bring up citation modal and not zoom the presentation tab. I guess if we use the hotkey for both tabs, the citation hotkey would only work if the focus is in the source pane or visual editor? I think it's probably better to not share the same hotkey in this case.

astayleraz commented 2 years ago

This should be fixed here https://github.com/rstudio/rstudio/commit/4c4a64f92cef7c9f30ad5530665dd2a0470e975b

astayleraz commented 2 years ago

Verified in 2022.01.0-daily+192.pro1 this is working again as expected and added the check back into the automation test on this. Closing issue.