Closed astayleraz closed 2 years ago
This should be fixed here https://github.com/rstudio/rstudio/commit/4c4a64f92cef7c9f30ad5530665dd2a0470e975b
Verified in 2022.01.0-daily+192.pro1 this is working again as expected and added the check back into the automation test on this. Closing issue.
System details
Steps to reproduce the problem
Automation failure: https://build.rstudioservices.com/job/IDE/job/qa-opensource-automation/903/testReport/rstudio_server_pro.tests.test_Citations/TestCitations/test_no_duplicate_citations/
Note: This was not an issue in 2021.12.0-daily+64.pro1 and the test was passing on this build. Not sure if this might be related to the work done in shortcuts in https://github.com/rstudio/rstudio/issues/9915
Test steps:
Describe the problem in detail
Actual: Zooms the presentation tab.
Looking at the modify keyboard shortcuts modal it looks like zoom presentation was newly added and shares the same hotkeys as insert citation.
Describe the behavior you expected
Expected: Should bring up citation modal and not zoom the presentation tab. I guess if we use the hotkey for both tabs, the citation hotkey would only work if the focus is in the source pane or visual editor? I think it's probably better to not share the same hotkey in this case.