RStudio does not detect orphaned accounts from rsconnect >= 0.8.25

jmcphers commented 2 years ago

System details

RStudio Edition : Both
RStudio Version : 2021.09.0+351

Steps to reproduce the problem

Install the rsconnect package, 0.8.25 or newer
Use it to establish one or more accounts on Connect
Uninstall the package
Shut down all RStudio instances
Open RStudio and go to Options -> Publishing

Describe the problem in detail

No publishing accounts are shown.

Describe the behavior you expected

RStudio should detect that you have accounts even though the rsconnect package is not installed. It should show a notice that it's detected orphaned accounts and prompt you to install the rsconnect package so you can see them.

This is necessitated by a recent change in the rsconnect package; due to new CRAN policy, it now has to store the accounts in a different folder: https://github.com/rstudio/rsconnect/pull/551

You can pick up the thread here to see where the IDE is looking for orphaned accounts:

https://github.com/rstudio/rstudio/blob/3a7302098babba3827d4f98aad2cb12c5e711977/src/cpp/session/modules/SessionRSConnect.R#L527-L529

[x] I have read the guide for submitting good bug reports.
[x] I have installed the latest version of RStudio, and confirmed that the issue still persists.
[x] If I am reporting an RStudio crash, I have included a diagnostics report.
[x] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

mikebessuille commented 2 years ago

@jmcphers is there a reason you feel this is critical enough to be in PT? It's a regression, but it only happens if you uninstall the package.

jmcphers commented 2 years ago

Only because it's a regression.

rstudio / rstudio